Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adding the WebWorker feature to WebARStudio #1

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

kalwalt
Copy link
Member

@kalwalt kalwalt commented May 12, 2020

This PR will add the WebWorker feature to the editor.
Features and code changed:

  • new jsartoolkitNFT with WASM as single file.
  • remove old jsartoolkit5 libs
  • remove all arController references outside the Worker (i.e. in the main thread)
  • new listeners to pass data from Worker to markerRoot
  • new getUserMedia function to pass the video
  • check if video is closed/deleted correctly
  • check if model/mesh is displayed
  • fix issue [Bug] unable to display a model #4

JsartoolkitNFT from master branch https://github.com/webarkit/jsartoolkitNFT

@kalwalt kalwalt added the enhancement New feature or request label May 12, 2020
@kalwalt kalwalt self-assigned this May 12, 2020
@kalwalt kalwalt marked this pull request as draft May 12, 2020 22:19
@kalwalt
Copy link
Member Author

kalwalt commented May 14, 2020

At the moment it can track the NFT marker, because i can see the messages in the console. The video is displayed but is not correclty closed/deleted when it is pushed the stop button. This need to be fixed. And model is not displayed probably need to be fixed some retrieved values (matrix or related stuff)

@kalwalt
Copy link
Member Author

kalwalt commented May 16, 2020

Things to do:

  • solve the video issue( not correctly stopped)
  • improve the mediaStream part
  • remove old dead code that refer to arController
  • better webWorker
  • solve issue with matrix (camera matrix?) cube appear as out of the screen.

@kalwalt
Copy link
Member Author

kalwalt commented Oct 12, 2020

I am back on this. 😄
trying to solve and finish this PR. I'm getting this error while detecting the pinball marker:

arcontroller.component.js?version=0.64:109 Uncaught TypeError: Cannot read property 'setPosition' of undefined
    at arcontroller.component.js?version=0.64:109
    at found (webWorker.js:189)
    at Worker.worker.onmessage (webWorker.js:60)

Probably markerRoot is not correct? I should compare my version code with the previous one, I think something is wrong in my implementation...

- need to fix this also in the master branch
- must be verified
@kalwalt
Copy link
Member Author

kalwalt commented Oct 26, 2020

@ThorstenBux i will apply that fix also in the master branch. Anyway this should be tested, before to merge it. I think we are very close for a new release...

@kalwalt kalwalt requested a review from ThorstenBux October 26, 2020 15:27
@kalwalt
Copy link
Member Author

kalwalt commented Oct 26, 2020

If someone want to try, test WebARStudio at this link

@kalwalt
Copy link
Member Author

kalwalt commented Nov 26, 2020

Tested again the code: with the latest, sometimes i receive the error already reported, not the same but it came from that:

arcontroller.component.js?version=0.64:91 Uncaught TypeError: Cannot read property 'childNodes' of null
    at arcontroller.component.js?version=0.64:91
    at found (webWorker.js:189)
    at Worker.worker.onmessage (webWorker.js:60)

it appear when i stop the video and restart the simulation.
The model also appear too big even if i set up to small size. I have no idea how to solve and why now this happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request NFT WebWorker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant